Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tacacs+: tacacs+ -> tacacsplus #68027

Merged
merged 1 commit into from Sep 3, 2019
Merged

Conversation

@0x4A6F
Copy link
Contributor

0x4A6F commented Sep 3, 2019

Motivation for this change

tacacs+ can't be referenced.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis @aanderse

@adisbladis

This comment has been minimized.

Copy link
Member

adisbladis commented Sep 3, 2019

Directories should also be renamed to match the attribute name.

@0x4A6F 0x4A6F force-pushed the 0x4A6F:master-tacacsplus branch from 1f8dce5 to 05ee758 Sep 3, 2019
@0x4A6F

This comment has been minimized.

Copy link
Contributor Author

0x4A6F commented Sep 3, 2019

Renamed directory and pname as well.

@adisbladis adisbladis merged commit 8f57bab into NixOS:master Sep 3, 2019
2 of 4 checks passed
2 of 4 checks passed
grahamcofborg-eval Beginning Evaluations
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@0x4A6F 0x4A6F deleted the 0x4A6F:master-tacacsplus branch Sep 3, 2019
@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Sep 3, 2019

@0x4A6F in future could you include stuff like “tacacs+ can't be referenced.” in your commit message body? Makes it much easier to refer to when looking at the Git repo. GitHub will automatically fill in new PRs with commit message bodies too, so you still only have to type it once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.