Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluentd: add cloudwatchlogs plugin #68028

Open
wants to merge 1 commit into
base: master
from

Conversation

@DzmitrySudnik
Copy link
Contributor

DzmitrySudnik commented Sep 3, 2019

And whatever got autoupgraded by running
bundle lock --update && bundix

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nicknovitski

And whatever autoupgraded by running
bundle lock --update && bundix
@risicle

This comment has been minimized.

Copy link
Contributor

risicle commented Sep 7, 2019

nix-review builds for me macos 10.13, all binaries can give me --help.

@DzmitrySudnik

This comment has been minimized.

Copy link
Contributor Author

DzmitrySudnik commented Oct 14, 2019

Hi @alyssais and @zimbatm , could you please review this?
Thank you

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Oct 15, 2019

Seems a bit weird to me that plugins are all bundled into this one package, and since I don’t know anything about the package, I don’t know what criteria we should be using to decide whether to include a plug-in or not.

I’d like to hear from @nicknovitski, the maintainer of the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.