Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default gcc to gcc9 #68029

Merged
merged 133 commits into from Dec 30, 2019
Merged

Default gcc to gcc9 #68029

merged 133 commits into from Dec 30, 2019

Conversation

@globin
Copy link
Member

globin commented Sep 3, 2019

Successor of #63132, based on it.

This will receive a hydra jobset after the above has been merged.

@fpletz fpletz force-pushed the gcc-9 branch from b2d8ce6 to 8f729c0 Nov 2, 2019
@fpletz

This comment has been minimized.

Copy link
Member

fpletz commented Nov 2, 2019

Rebased onto current master. Created hydra jobset: https://hydra.nixos.org/jobset/nixpkgs/gcc-9

Already built firefox and its dependencies successfully. This might be an easy bump. \o/

@ofborg ofborg bot removed the 6.topic: ruby label Nov 2, 2019
@ofborg ofborg bot requested review from andir, np, edolstra and lovek323 Nov 2, 2019
fpletz added 5 commits Nov 2, 2019
@ofborg ofborg bot requested a review from luispedro Nov 2, 2019
fpletz added 7 commits Nov 2, 2019
fpletz and others added 7 commits Dec 30, 2019
Some tests don't work well with gcc9 atm, those tests use CC from
`buildPackages.stdenv.cc` which had to be modified for Aarch64 as well.
Newer `iasl`-versions disallow strings within certain declarations[1]
which breaks the virtualbox build as it relies on exactly this
behavior[2].

This should be removed again when updating virtualbox to 6.1.

[1] https://acpica.org/node/172
[2] https://hydra.nixos.org/build/108774352
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Dec 30, 2019

The Hydra builds look good. Is there an intent to merge this in the coming days? Both this branch and staging-next seem ready, so depending on how we merge we will need to do at least one more rebuild of either.

@fpletz

This comment has been minimized.

Copy link
Member

fpletz commented Dec 30, 2019

@FRidh Yup, that was our intention. There are still some minor packages that are failing but are difficult to fix. The maintainers have to take care of those.

Since I'm not involved in the current staging processes, when would be the best time to merge in your opinion? We wanted to do another master-merge and eval since we wanted to test if the go aarch64 build fail is finally fixed.

@fpletz fpletz marked this pull request as ready for review Dec 30, 2019
@fpletz fpletz changed the title [WIP] Default gcc to gcc9 Default gcc to gcc9 Dec 30, 2019
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Dec 30, 2019

Great! I'm going to merge staging-next now/today. I therefore suggest merging this in the current staging. Then you have the whole staging-next period to further submit fixes before it lands in master.

@FRidh FRidh changed the base branch from master to staging Dec 30, 2019
@FRidh FRidh added this to WIP in Staging via automation Dec 30, 2019
FRidh added a commit that referenced this pull request Dec 30, 2019
@FRidh FRidh merged commit 59ab29f into staging Dec 30, 2019
1 check failed
1 check failed
grahamcofborg-eval Failed to merge
Details
Staging automation moved this from WIP to Done Dec 30, 2019
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Dec 30, 2019

These changes are now in staging-next (#76705).

@Ma27

This comment has been minimized.

Copy link
Member

Ma27 commented Dec 30, 2019

Great, thanks!

@fpletz

This comment has been minimized.

Copy link
Member

fpletz commented Dec 30, 2019

Awesome! Thanks! 🎉

@Ma27 Ma27 deleted the gcc-9 branch Dec 30, 2019
@gnidorah gnidorah mentioned this pull request Jan 22, 2020
3 of 10 tasks complete
@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Jan 27, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-20-03-feature-freeze/5655/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.