Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: s/GTK+/GTK/g #68031

Merged
merged 2 commits into from Sep 6, 2019
Merged

tree-wide: s/GTK+/GTK/g #68031

merged 2 commits into from Sep 6, 2019

Conversation

@jtojnar
Copy link
Contributor

jtojnar commented Sep 3, 2019

GTK was renamed.

Did not rename the derivation yet to avoid the mass rebuild.

See: #57887

cc @worldofpeace

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Sep 5, 2019

Don't think there's anymore occurrences.

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Sep 5, 2019

Do you want to do ebb66ee and derivation rename on staging (another PR)?

We can merge just the

Remove all references to gtk+ in documentation, package descriptions, and comments.

easily to master.

@jtojnar

This comment has been minimized.

Copy link
Contributor Author

jtojnar commented Sep 6, 2019

I would merge this and than merge master→staging-next→staging. And then do the derivation rename in a separate PR.

jtojnar added 2 commits Sep 3, 2019
GTK was renamed.
@jtojnar jtojnar force-pushed the jtojnar:gtk-no-plus branch from b72e964 to 684bad0 Sep 6, 2019
@jtojnar jtojnar merged commit 684bad0 into NixOS:master Sep 6, 2019
7 of 9 checks passed
7 of 9 checks passed
grahamcofborg-eval Beginning Evaluations
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar jtojnar deleted the jtojnar:gtk-no-plus branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.