Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upower: 0.99.10 -> 0.99.11 #68037

Merged
merged 5 commits into from Sep 8, 2019
Merged

Conversation

@dtzWill
Copy link
Contributor

dtzWill commented Sep 3, 2019

Motivation for this change

https://gitlab.freedesktop.org/upower/upower/-/tags/UPOWER_0_99_11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Sep 7, 2019

Could you move the following to nativeBuildInputs:

intltool
libxslt
docbook_xsl
gobject-introspection

and replace intltool by gettext as suggested in the news?

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Sep 8, 2019

@jtojnar Did that and then some 👍

@worldofpeace worldofpeace force-pushed the dtzWill:update/upower-0.99.11 branch from 29e0de7 to 7c6c59d Sep 8, 2019
@worldofpeace worldofpeace force-pushed the dtzWill:update/upower-0.99.11 branch from 7c6c59d to 2d2194e Sep 8, 2019
@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Sep 8, 2019

Given that we hard depend on libgudev, which is glib wrapper around udev, which is part of systemd, useSystemd = false does not make sense anymore.

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Sep 8, 2019

Given that we hard depend on libgudev, which is glib wrapper around udev, which is part of systemd, useSystemd = false does not make sense anymore.

It seems that polkit and pulseaudio have a useSystemd as well. Wonder if the situation is similar to this one.

worldofpeace added 4 commits Sep 8, 2019
* correct inputs
* drop dbus-glib
  Has not been needed for a very long
  time.
* intltool -> gettext
* add optional libimobiledevice
* propagate glib
  It's in Requires
* dev output
* drop useSystemd
All of these changes ++ are in the upstream unit
Also drop glib in path of unit as I don't believe
this should be needed anymore.
Introduced 7 years ago, it's likely the issue has
been fixed. Even possible this could cause issues
with recent upower.
@worldofpeace worldofpeace force-pushed the dtzWill:update/upower-0.99.11 branch from 2d2194e to 16083de Sep 8, 2019
@jtojnar
jtojnar approved these changes Sep 8, 2019
@worldofpeace worldofpeace merged commit 362c2f6 into NixOS:master Sep 8, 2019
16 checks passed
16 checks passed
upower on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
upower on aarch64-linux Success
Details
upower on x86_64-linux Success
Details
@dtzWill dtzWill deleted the dtzWill:update/upower-0.99.11 branch Sep 9, 2019
@dtzWill

This comment has been minimized.

Copy link
Contributor Author

dtzWill commented Sep 9, 2019

@worldofpeace 😍 thanks, this is great! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.