Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libphonenumber: 8.9.9 -> 8.10.17 #68067

Closed
wants to merge 2 commits into from

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Sep 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Thanks @jonringer!

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@dtzWill dtzWill force-pushed the dtzWill:update/libphonenumber-8.10.17 branch from 19eec07 to 3bae6c2 Sep 5, 2019
Copy link
Contributor

@jonringer jonringer left a comment

nix-review passes on NixOS
diff LGTM (some suggestions)
leaf package

[3 built, 15 copied (226.5 MiB), 27.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68067
1 package were build:
libphonenumber

I think the darwin build might work if you did something like:

buildInputs = [...]
++ stdenv.lib.optionals stdenv.isDarwin [ libiconv CoreFoundation ];

seems to not be able to link against corefoundation

@@ -1,17 +1,17 @@
{ stdenv, fetchFromGitHub, cmake, gmock, boost, pkgconfig, protobuf, icu }:

let
version = "8.9.9";
version = "8.10.17";
in
stdenv.mkDerivation {

This comment has been minimized.

@jonringer

jonringer Sep 5, 2019
Contributor

Suggested change
stdenv.mkDerivation {
stdenv.mkDerivation rec {
in
stdenv.mkDerivation {
name = "phonenumber-${version}";
pname = "phonenumber";
inherit version;

This comment has been minimized.

@jonringer

jonringer Sep 5, 2019
Contributor

Suggested change
inherit version;
version = "8.10.17";
@@ -1,17 +1,17 @@
{ stdenv, fetchFromGitHub, cmake, gmock, boost, pkgconfig, protobuf, icu }:

let
version = "8.9.9";
version = "8.10.17";

This comment has been minimized.

@jonringer

jonringer Sep 5, 2019
Contributor

Just my preference, but I would move the version attr into the derivation

Suggested change
version = "8.10.17";
@JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Feb 9, 2020

We've got 8.10.20 since ##70496, even with the additional proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.