Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unsupported go versions 1.10 and 1.11 #68176

Closed
wants to merge 17 commits into from

Conversation

@adisbladis
Copy link
Member

commented Sep 5, 2019

Motivation for this change

These versions are no longer supported by upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Can maintainers of packages marked as broken fix your respective packages in a separate PR and reference this PR so I can drop those commits setting broken = true?
cc @fpletz @nlewo

Also CCing the contributors who latest updated those packages:
@volth @kamilchm

I'd like a solution to all filebeats version using pinned old compiler versions, they are currently the only thing left in the tree referencing buildGo111Package.
CC beats maintainers @fadenb @basvandijk

CCing Go maintainers
@cstrahan @orivej @velovix @Mic92

adisbladis added 17 commits Sep 5, 2019
perkeep: 0.10.1 -> unstable-2019-07-29
0.10.1 is the latest release but it doesn't build with recent go versions
go-ethereum-classic: Drop package
It's unmaintained for years and doesn't build with Go 1.12
fscrypt: 0.2.4 -> unstable-2019-08-29
Fix build with go 1.12
go_1_10: Drop package
It's unsupported by upstream.
skydive: Mark as broken
Does not build with go 1.12
mirrorbits: Mark as broken
Does not build with go 1.12
mongodb-tools: Mark as broken
Does not build with go 1.12
go_1_11: Drop package
It's unsupported

@ofborg ofborg bot added the 6.topic: golang label Sep 5, 2019

@adisbladis

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

I'm going to split this into two PRs: One handling Go 1.10 and one handling Go 1.11.

@adisbladis adisbladis closed this Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.