Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unsupported go version 1.10 #68194

Merged
merged 13 commits into from Sep 6, 2019

Conversation

@adisbladis
Copy link
Member

commented Sep 6, 2019

Motivation for this change

Go 1.10 is unsupported by upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

adisbladis added 13 commits Sep 5, 2019
perkeep: 0.10.1 -> unstable-2019-07-29
0.10.1 is the latest release but it doesn't build with recent go versions
go-ethereum-classic: Drop package
It's unmaintained for years and doesn't build with Go 1.12
fscrypt: 0.2.4 -> unstable-2019-08-29
Fix build with go 1.12
go_1_10: Drop package
It's unsupported by upstream.
@adisbladis

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

@GrahamcOfBorg build prometheus-snmp-exporter diskrsync prometheus_1 perkeep dnscrypt-proxy2 tmsu notary goa ipget fscrypt

@adisbladis

This comment has been minimized.

@adisbladis adisbladis referenced this pull request Sep 6, 2019
0 of 10 tasks complete
@vdemeester
Copy link
Member

left a comment

Sounds good to me 👍

@WilliButz

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

@GrahamcOfBorg test prometheus-exporters.snmp

LGTM 👍
As a sidenote, I personally think we need to drop prometheus1 asap but that's out of scope for this PR and should be done separately :)

@FRidh FRidh merged commit 9b92496 into NixOS:master Sep 6, 2019

21 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
diskrsync, dnscrypt-proxy2, fscrypt, goa, ipget, notary, perkeep, prometheus-snmp-exporter, prometheus_1, tmsu on aarch64-linux Success
Details
diskrsync, dnscrypt-proxy2, fscrypt, goa, ipget, notary, perkeep, prometheus-snmp-exporter, prometheus_1, tmsu on x86_64-darwin Success
Details
diskrsync, dnscrypt-proxy2, fscrypt, goa, ipget, notary, perkeep, prometheus-snmp-exporter, prometheus_1, tmsu on x86_64-linux Success
Details
diskrsync, dnscrypt-proxy2, goa, ipget, meguca, notary, perkeep, prometheus-snmp-exporter, prometheus_1, tmsu on aarch64-linux Success
Details
diskrsync, dnscrypt-proxy2, goa, ipget, meguca, notary, perkeep, prometheus-snmp-exporter, prometheus_1, tmsu on x86_64-darwin Success
Details
diskrsync, dnscrypt-proxy2, goa, ipget, meguca, notary, perkeep, prometheus-snmp-exporter, prometheus_1, tmsu on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.prometheus-exporters.snmp on aarch64-linux Success
Details
tests.prometheus-exporters.snmp on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.