Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trousers to latest, use regular openssl #68338

Merged
merged 2 commits into from Nov 11, 2019
Merged

Conversation

@reanimus
Copy link
Contributor

reanimus commented Sep 9, 2019

Motivation for this change

Fixes bugs with apps using newer versions of openssl. Fixes #68320

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers
* some CFLAGS and LDFLAGS are not needed anymore

* libtool file fixup was a no-op

* license is now BSD-3 since:
https://sourceforge.net/p/trousers/trousers/ci/0160d229f8fbab7c6900662155f42050e3d563a0/
@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Nov 11, 2019

@GrahamcOfBorg build simpleTpmPk11 opencryptoki tboot tpm-tools

@c0bw3b
c0bw3b approved these changes Nov 11, 2019
Copy link
Contributor

c0bw3b left a comment

Result of nix-review pr 68338 1

3 package are marked as broken and were skipped:
  • chaps
  • gnutls-kdh
  • tlspool
11 package were build:
  • opencryptoki
  • pond
  • rkt
  • simpleTpmPk11
  • strongswanTNC
  • tboot
  • tpm-luks
  • tpm-quote-tools
  • tpm-tools
  • tpmmanager
  • trousers
@c0bw3b c0bw3b merged commit 82dfacc into NixOS:master Nov 11, 2019
18 checks passed
18 checks passed
opencryptoki, simpleTpmPk11, tboot, tpm-tools on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
opencryptoki, simpleTpmPk11, tboot, tpm-tools on aarch64-linux Success
Details
opencryptoki, simpleTpmPk11, tboot, tpm-tools on x86_64-linux Success
Details
trousers on aarch64-linux Success
Details
trousers on x86_64-linux Success
Details
c0bw3b added a commit that referenced this pull request Nov 11, 2019
* Update trousers to latest, use regular openssl (#68338)

trousers: cleanup

* some CFLAGS and LDFLAGS are not needed anymore

* libtool file fixup was a no-op

* license is now BSD-3 since:
https://sourceforge.net/p/trousers/trousers/ci/0160d229f8fbab7c6900662155f42050e3d563a0/

(cherry picked from commit 82dfacc)
juaningan added a commit to juaningan/nixpkgs that referenced this pull request Nov 11, 2019
* Update trousers to latest, use regular openssl (NixOS#68338)

trousers: cleanup

* some CFLAGS and LDFLAGS are not needed anymore

* libtool file fixup was a no-op

* license is now BSD-3 since:
https://sourceforge.net/p/trousers/trousers/ci/0160d229f8fbab7c6900662155f42050e3d563a0/
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 11, 2019
* Update trousers to latest, use regular openssl (NixOS#68338)

trousers: cleanup

* some CFLAGS and LDFLAGS are not needed anymore

* libtool file fixup was a no-op

* license is now BSD-3 since:
https://sourceforge.net/p/trousers/trousers/ci/0160d229f8fbab7c6900662155f42050e3d563a0/

(cherry picked from commit 82dfacc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.