Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.mulpyplexer: init at 0.08 #68429

Closed
wants to merge 1 commit into from

Conversation

@Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Sep 10, 2019

Motivation for this change

I am trying to make angr, the binary analysis framework, available on NixOS.
This is part of the modules it requires.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
@Pamplemousse Pamplemousse force-pushed the Pamplemousse:mulpyplexer branch from 3ec6345 to d396d8e Sep 10, 2019
Copy link
Contributor

@jonringer jonringer left a comment

nix-review passes on NixOS
diff LGTM

no tests, but repo doesn't have tests :(
I would say, "As good as the pypi package" :)

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@Pamplemousse
Copy link
Member Author

@Pamplemousse Pamplemousse commented Dec 6, 2019

I started https://github.com/angr/nixpkgs , and it should be added to NUR following nix-community/NUR#160.
Closed as an angr related package.

@Pamplemousse Pamplemousse deleted the Pamplemousse:mulpyplexer branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.