Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.z3-solver: init at 4.8.5.0 #68430

Closed
wants to merge 1 commit into from

Conversation

@Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Sep 10, 2019

Motivation for this change

I am trying to make angr, the binary analysis framework, available on NixOS.
This is part of the modules it requires.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
@Pamplemousse Pamplemousse force-pushed the Pamplemousse:z3-solver branch from 99724c9 to a90c099 Sep 10, 2019
Copy link
Contributor

@jonringer jonringer left a comment

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

@MetaDark
Copy link
Contributor

@MetaDark MetaDark commented Sep 12, 2019

It looks like this duplicates the existing z3 python package. It should probably be renamed to z3-solver, since another completely unrelated package called z3 exists in PyPI, which may be confusing.

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@Pamplemousse
Copy link
Member Author

@Pamplemousse Pamplemousse commented Sep 12, 2019

@MetaDark Oh right, I missed the fact that the hard work has been already done...

Trying out the existing z3 with the rest of my angr expressions.
Will close if this is not needed.

@Pamplemousse Pamplemousse force-pushed the Pamplemousse:z3-solver branch from a90c099 to e9c4c67 Sep 12, 2019
@FRidh FRidh self-assigned this Sep 13, 2019
Copy link
Member

@FRidh FRidh left a comment

z3 already exists. Do we need this additional package?

pname = "z3-solver";
version = "4.8.5.0";

src = fetchPypi {

This comment has been minimized.

@FRidh

FRidh Sep 13, 2019
Member

please include a link to the actual source in the correct repo/branch. It seems quite hard to find it.

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 15, 2019

@Pamplemousse will you continue with this? As mentioned, it looks like z3 is already present.

@Pamplemousse
Copy link
Member Author

@Pamplemousse Pamplemousse commented Nov 15, 2019

@FRidh Not anytime soon.

Z3 is already present, but some developpers behind angr host a specific package on PyPi.
Not willing to inverstigate further what the differences are (and if the current Z3 in nixpkgs is up to the job) for now.

Closing, will re-open if I ever want to dig into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.