Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel-deps: remove #68469

Merged
merged 1 commit into from Feb 4, 2020
Merged

bazel-deps: remove #68469

merged 1 commit into from Feb 4, 2020

Conversation

@uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Sep 11, 2019

Motivation for this change

This has been broken for a while, and now that there's an official rule set to support maven dependencies in Bazel (https://github.com/bazelbuild/rules_jvm_external) this is much less useful.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ryantm @orivej @Profpatsch @abbradar

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Sep 11, 2019

Instead of removing it I would throw an error with basically your description if somebody tries to build the attribute.

@uri-canva
Copy link
Contributor Author

@uri-canva uri-canva commented Sep 11, 2019

Sounds good, do you know an example derivation that does that off the top of your head so I can see how to do that?

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Sep 12, 2019

just search all-packages.nix for throw'

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@lheckemann
Copy link
Member

@lheckemann lheckemann commented Sep 12, 2019

-1 for throw, since we already had errors saying it was broken.

@uri-canva uri-canva force-pushed the uri-canva:bazel-deps branch from 2aec594 to 7c6dfc2 Sep 23, 2019
@uri-canva uri-canva changed the title bazel-deps: remove bazel-deps: 2019-07-11 -> 2019-09-11 Sep 23, 2019
@uri-canva
Copy link
Contributor Author

@uri-canva uri-canva commented Sep 23, 2019

Figured if we're not agree on removing it, or adding a throw, might as well update it and fix it.

@uri-canva
Copy link
Contributor Author

@uri-canva uri-canva commented Sep 23, 2019

It's still not working with sandbox, let me fix that.

@abbradar
Copy link
Member

@abbradar abbradar commented Sep 23, 2019

@GrahamcOfBorg build bazel-deps

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Nov 12, 2019

So, should we try upgrading it, remove, or just mark as broken?

@uri-canva
Copy link
Contributor Author

@uri-canva uri-canva commented Nov 12, 2019

I think we should remove it, but I'm happy for it to be upgraded, I just got stuck on this error:

src/main/tools/linux-sandbox-pid1.cc:427: "execvp(external/remotejdk11_linux/bin/javac, 0x42be70)": No such file or directory

I think I saw it on another bazel related derivation but I can't remember which one.

@uri-canva uri-canva force-pushed the uri-canva:bazel-deps branch 4 times, most recently from 89ce66f to f20a335 Dec 16, 2019
@uri-canva
Copy link
Contributor Author

@uri-canva uri-canva commented Jan 2, 2020

What I found out is in buildBazelPackage when we delete all the local repositories expecting Bazel to recreate them without network we don't support the remote jdk: that is because when the local jdk repository is recreated it cannot handle is the case of the remote jdk already having being downloaded.

@uri-canva
Copy link
Contributor Author

@uri-canva uri-canva commented Feb 4, 2020

This is broken due to bazelbuild/bazel#10280. I'm going to change the PR back to deleting this package.

@uri-canva uri-canva changed the title bazel-deps: 2019-07-11 -> 2019-09-11 bazel-deps: remove Feb 4, 2020
@uri-canva uri-canva force-pushed the uri-canva:bazel-deps branch from f20a335 to 10d1a04 Feb 4, 2020
@Profpatsch Profpatsch merged commit 84630a1 into NixOS:master Feb 4, 2020
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jamesthompson
Copy link

@jamesthompson jamesthompson commented Sep 1, 2020

I believe this can be fixed if you just tell bazel to use the local jdk provisioned within the nix build env
I have this in my .bazelrc file. Not sure how you would override this in the nix bazel build function call...

build --host_javabase='@local_jdk//:jdk'
build --java_toolchain='@bazel_tools//tools/jdk:toolchain_hostjdk8'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.