Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/shells-environment: Make ~/bin/ in $PATH optional #68483

Merged
merged 1 commit into from Nov 2, 2019

Conversation

@chkno
Copy link
Contributor

chkno commented Sep 11, 2019

Motivation for this change

I don't want ~/bin/ in $PATH. Without this new option, I didn't find a way to override setEnvironment to make it stop adding ~/bin/ to PATH without either copy/pasting its implementation into my configs or setting cfg.extraInit = "return"; both of which are very brittle workarounds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

nixos/modules/config/shells-environment.nix Outdated Show resolved Hide resolved
@andir

This comment has been minimized.

Copy link
Member

andir commented Sep 12, 2019

@chkno changes look good. Could you squash them together?

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@chkno chkno force-pushed the chkno:optional-home-bin-in-path branch from 54257cc to b6c97ca Sep 12, 2019
@chkno

This comment has been minimized.

Copy link
Contributor Author

chkno commented Sep 12, 2019

I squashed them together and then force-pushed the the pull-request branch. Is that what you meant, or should I have started a new branch?

Thanks!

@andir

This comment has been minimized.

Copy link
Member

andir commented Sep 12, 2019

@chkno

This comment has been minimized.

Copy link
Contributor Author

chkno commented Sep 18, 2019

Anything else I should do?

@ck3d
ck3d approved these changes Sep 23, 2019
@chkno chkno requested a review from andir Sep 24, 2019
@andir

This comment has been minimized.

Copy link
Member

andir commented Nov 2, 2019

@chkno Thank you for the change. It looks good 👍.

@andir andir merged commit 5d5b140 into NixOS:master Nov 2, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@andir andir mentioned this pull request Nov 2, 2019
0 of 10 tasks complete
@chkno chkno deleted the chkno:optional-home-bin-in-path branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.