Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macvim: fix compatibility with Xcode 11 #68534

Open
wants to merge 1 commit into
base: master
from

Conversation

@lilyball
Copy link
Member

commented Sep 12, 2019

Motivation for this change

This fixes several Xcode 11 incompatibilities with MacVim, including an issue where it wasn't inheriting the deployment target correctly to begin with.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I haven't actually tested but I'm pretty sure this package doesn't compile under sandbox, so don't bother trying.

Also see #68528. I tested by building with both patches applied simultaneously.

I haven't actually tested compiling this with Xcode 10.3 via Nix, but I did test the patches independently with Xcode 10.3 in a separate checkout of the MacVim project.

macvim: fix compatibility with Xcode 11
This fixes several Xcode 11 incompatibilities with MacVim, including an
issue where it wasn't inheriting the deployment target correctly to
begin with.
@lilyball

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

Also see macvim-dev/macvim#936 which is the tracking issue on the MacVim side for Xcode 11 compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.