Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electrum.ltc: 3.1.3.1 -> 3.3.8.1 #68555

Closed
wants to merge 1 commit into from
Closed

Conversation

@mmahut
Copy link
Member

@mmahut mmahut commented Sep 12, 2019

Motivation for this change

Backporting #68514 into 19.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

(cherry picked from commit 4c38d83)
@asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Sep 16, 2019

Couldn't run this:

❯ nix-review pr 68555
$ git fetch --force https://github.com/NixOS/nixpkgs release-19.09:refs/nix-review/0 pull/68555/head:refs/nix-review/1
remote: Enumerating objects: 576, done.
remote: Counting objects: 100% (576/576), done.
remote: Total 1054 (delta 575), reused 576 (delta 575), pack-reused 478
Receiving objects: 100% (1054/1054), 939.73 KiB | 1.69 MiB/s, done.
Resolving deltas: 100% (818/818), completed with 113 local objects.
From https://github.com/NixOS/nixpkgs
 + 046ea6d08fc...4976c82fb00 release-19.09        -> refs/nix-review/0  (forced update)
 + 4c38d83e63c...22cb5196ca2 refs/pull/68555/head -> refs/nix-review/1  (forced update)
 * [new tag]                 19.09-beta           -> 19.09-beta
$ git worktree add /home/asymmetric/.cache/nix-review/pr-68555/nixpkgs 4976c82fb0022d96c65a3c429e4218f92c11cc87
Preparing worktree (detached HEAD 4976c82fb00)
Checking out files: 100% (19792/19792), done.
HEAD is now at 4976c82fb00 ccacheWrapper: make usable with clang
$ git merge --no-commit 22cb5196ca20f723fe810cc0f909cc5269a3aa5b
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/asymmetric/.cache/nix-review/pr-68555/build.nix
[2 built, 133 copied (472.8 MiB), 78.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68555
1 package were build:
electrum-ltc

$ nix-shell /home/asymmetric/.cache/nix-review/pr-68555/shell.nix

[nix-shell:~/.cache/nix-review/pr-68555]$ results/electrum-ltc/bin/electrum-ltc
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted
@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Oct 25, 2019

I tried it with wrapQtHook, but couldn't get it to run

Copy link
Contributor

@asymmetric asymmetric left a comment

Some changes needed to make it build. I'm not using this anymore and removed myself from the maintainers btw.

@mmahut
Copy link
Member Author

@mmahut mmahut commented Oct 31, 2019

Cold not make it work for some reason, I will take a look over the weekend.

@mmahut mmahut closed this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.