Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broot: 0.9.4 -> 0.10.2 #68914

Merged
merged 1 commit into from Nov 16, 2019
Merged

broot: 0.9.4 -> 0.10.2 #68914

merged 1 commit into from Nov 16, 2019

Conversation

@dtzWill
Copy link
Contributor

dtzWill commented Sep 16, 2019

Motivation for this change

https://github.com/Canop/broot/releases/tag/v0.9.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

dtzWill commented Sep 16, 2019

Hmm, does the cargoSha256 look right? Double-checking because other hashes are off in my tree, presumably missed a rust-related bump or something.

@dtzWill dtzWill force-pushed the dtzWill:update/broot-0.9.5 branch from 1aab932 to f3e0130 Oct 7, 2019
@dtzWill

This comment has been minimized.

Copy link
Contributor Author

dtzWill commented Oct 7, 2019

Replaced cargo hash with ofborg's computed value, rebased to make sure all good on master.

@ofborg ofborg bot requested a review from magnetophon Oct 7, 2019
@dtzWill dtzWill force-pushed the dtzWill:update/broot-0.9.5 branch from f3e0130 to 3344f3e Nov 16, 2019
@dtzWill dtzWill changed the title broot: 0.9.4 -> 0.9.5 broot: 0.9.4 -> 0.10.2 Nov 16, 2019
@ofborg ofborg bot requested a review from magnetophon Nov 16, 2019
Copy link
Member

magnetophon left a comment

Tested with nix-review, LGTM!

@dtzWill dtzWill merged commit ed2819a into NixOS:master Nov 16, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
broot on aarch64-linux Success
Details
broot on x86_64-darwin Success
Details
broot on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dtzWill dtzWill deleted the dtzWill:update/broot-0.9.5 branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.