Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pastel: init at 0.5.3 #68921

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@davidtwco
Copy link
Contributor

commented Sep 16, 2019

Motivation for this change

Add a package for pastel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

N/A

pkgs/applications/misc/pastel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/pastel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/pastel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/pastel/default.nix Outdated Show resolved Hide resolved
@davidtwco davidtwco force-pushed the davidtwco:pastel-init branch from 832b6d1 to 80ddf72 Sep 17, 2019
Copy link
Contributor

left a comment

Builds with nix-review and runs on nixos

@dtzWill

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

What's the relation to #67960? One of these probably should be closed...? :)

@alexarice

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

What's the relation to #67960? One of these probably should be closed...? :)

I've managed to review both somehow

@mtrsk

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

What's the relation to #67960? One of these probably should be closed...? :)

I can close mine so this one can be merged.

@worldofpeace worldofpeace merged commit 7e36240 into NixOS:master Sep 25, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

Thanks for contributing @davidtwco.

Sorry about the PR duplication @mtrsk, this can occasionally happen with how active the nixpkgs contributors are with packaging.

dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Sep 25, 2019
pastel: init at 0.5.3
(cherry picked from commit 7e36240)
@mtrsk

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

Sorry about the PR duplication @mtrsk, this can occasionally happen with how active the nixpkgs contributors are with packaging.

No prob, I still plan to help the project, especially with broken packages that appear now and then.

@davidtwco davidtwco deleted the davidtwco:pastel-init branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.