Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mle: init at 1.4.1 #68949

Merged
merged 2 commits into from Nov 7, 2019
Merged

mle: init at 1.4.1 #68949

merged 2 commits into from Nov 7, 2019

Conversation

@adsr
Copy link
Contributor

adsr commented Sep 17, 2019

Motivation for this change

Small, flexible, terminal-based text editor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@teto

This comment has been minimized.

Copy link
Contributor

teto commented Sep 17, 2019

@GrahamcOfBorg build mle

@@ -184,6 +184,12 @@
githubId = 1250775;
name = "Adolfo E. García Castro";
};
adsr = {

This comment has been minimized.

Copy link
@alexarice

alexarice Sep 17, 2019

Contributor

The addition to maintainers.nix should be in a separate commit titled "maintainers: add adsr"

buildInputs = [ termbox pcre uthash lua5_3 ];

doCheck = true;
checkPhase = "make test";

This comment has been minimized.

Copy link
@alexarice

alexarice Sep 17, 2019

Contributor

I believe this should be the default checkPhase

};

postPatch = ''
substituteInPlace Makefile --replace "-llua5.3" "-llua";

This comment has been minimized.

Copy link
@alexarice

alexarice Sep 17, 2019

Contributor

Might be worth putting some motivation for these somewhere, did you create this fix yourself or is it from somewhere else

This comment has been minimized.

Copy link
@alexarice

alexarice Sep 17, 2019

Contributor

Have just realised this is your own project, is there any reason this can't be upstreamed?

This comment has been minimized.

Copy link
@adsr

adsr Sep 17, 2019

Author Contributor

The version in trunk (-llua5.3 / <lua5.3/lua.h>) works with Debian-based systems. Alternatives to this are using pkg-config or trying to guess the location of Lua dynamically. Personally I prefer this small patch as I find it the simplest to read.

@adsr adsr force-pushed the adsr:feature/mle branch 2 times, most recently from 2c2ecef to 8fef7b1 Sep 17, 2019
@adsr adsr changed the title mle: init at 1.4.0 mle: init at 1.4.1 Sep 21, 2019
@adsr adsr force-pushed the adsr:feature/mle branch from 8fef7b1 to c7a9213 Sep 21, 2019
@matthewbauer matthewbauer merged commit 1cee79c into NixOS:master Nov 7, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
mle: init at 1.4.1
(cherry picked from commit 1cee79c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.