Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cri-tools: 1.15.0 -> 1.16.1 #69098

Merged
merged 1 commit into from Nov 19, 2019
Merged

cri-tools: 1.15.0 -> 1.16.1 #69098

merged 1 commit into from Nov 19, 2019

Conversation

@saschagrunert
Copy link
Member

saschagrunert commented Sep 19, 2019

Motivation for this change

Update cri-tools to the latest release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

None

@saschagrunert

This comment has been minimized.

Copy link
Member Author

saschagrunert commented Sep 19, 2019

@GrahamcOfBorg build cri-tools

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert force-pushed the saschagrunert:cri-tools branch from 0fefba8 to 10fe9b1 Oct 2, 2019
@saschagrunert saschagrunert changed the title cri-tools: 1.15.0 -> 1.16.0 cri-tools: 1.15.0 -> 1.16.1 Oct 2, 2019
@saschagrunert

This comment has been minimized.

Copy link
Member Author

saschagrunert commented Oct 2, 2019

Update to 1.16.1

@saschagrunert saschagrunert mentioned this pull request Oct 15, 2019
9 of 10 tasks complete
@saschagrunert

This comment has been minimized.

Copy link
Member Author

saschagrunert commented Nov 17, 2019

@srhb do you think we can merge this update as well for k8s 1.16?

@srhb

This comment has been minimized.

Copy link
Contributor

srhb commented Nov 17, 2019

@saschagrunert Absolutely! I'll give it a quick spin.

@srhb

This comment has been minimized.

Copy link
Contributor

srhb commented Nov 17, 2019

Basic functionality looks good. I haven't tested actually talking to a CRI server. This might be nice to have in a test somewhere, at some point. :)

@srhb

This comment has been minimized.

Copy link
Contributor

srhb commented Nov 17, 2019

Looking at the diff, is there any reason to not have make install BINDIR[...] in the installPhase?

@saschagrunert

This comment has been minimized.

Copy link
Member Author

saschagrunert commented Nov 17, 2019

Looking at the diff, is there any reason to not have make install BINDIR[...] in the installPhase?

Hm no I think this is actually needed to install it not into the $GOPATH/bin

@srhb srhb merged commit 6a0486b into NixOS:master Nov 19, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
cri-tools on aarch64-linux Success
Details
cri-tools on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@saschagrunert saschagrunert deleted the saschagrunert:cri-tools branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.