Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mattermost: 5.9.0 -> 5.15.0 #69125

Merged
merged 3 commits into from Feb 13, 2020
Merged

mattermost: 5.9.0 -> 5.15.0 #69125

merged 3 commits into from Feb 13, 2020

Conversation

@jslight90
Copy link
Contributor

@jslight90 jslight90 commented Sep 19, 2019

Motivation for this change

Software update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested review from ryantm and fpletz Sep 20, 2019
@jslight90 jslight90 changed the title mattermost: 5.9.0 -> 5.15.0 WIP: mattermost: 5.9.0 -> 5.15.0 Sep 20, 2019
@jslight90 jslight90 force-pushed the jslight90:mattermost-5.15 branch from 131b09a to dfd8dd9 Sep 20, 2019
@jslight90 jslight90 force-pushed the jslight90:mattermost-5.15 branch from dfd8dd9 to 346a6ce Sep 23, 2019
@tomfitzhenry
Copy link
Contributor

@tomfitzhenry tomfitzhenry commented Nov 23, 2019

@jslight90 , is this still WIP?

@jslight90 jslight90 changed the title WIP: mattermost: 5.9.0 -> 5.15.0 mattermost: 5.9.0 -> 5.15.0 Nov 25, 2019
@jslight90
Copy link
Contributor Author

@jslight90 jslight90 commented Nov 25, 2019

@jslight90 , is this still WIP?

No, I forgot to update it. We have about 50 users and have been using 5.15.0 for about 2 months without any issues.

@bgamari
Copy link
Contributor

@bgamari bgamari commented Feb 13, 2020

It sounds like this can be merged.

@ryantm
ryantm approved these changes Feb 13, 2020
@ryantm ryantm merged commit 5a358ea into NixOS:master Feb 13, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@nh2
Copy link
Contributor

@nh2 nh2 commented May 29, 2020

This version did not work for me: #89194 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.