Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedpkg: fix build #69128

Closed
wants to merge 1 commit into from
Closed

fedpkg: fix build #69128

wants to merge 1 commit into from

Conversation

@refnil
Copy link
Contributor

@refnil refnil commented Sep 20, 2019

Motivation for this change

Zero Hydra Failures: 19.09 edition!

Things done

Add git in checkInputs for the package fedpkg.

  • [ X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ X] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut
Copy link
Member

@mmahut mmahut commented Sep 20, 2019

@GrahamcOfBorg build fedpkg

@mmahut
Copy link
Member

@mmahut mmahut commented Sep 20, 2019

Failure on darwin.

/nix/store/g2rm01l9fj099cbwhyd015izvvyi4v45-setuptools-check-hook/nix-support/setup-hook: line 4: 38426 Illegal instruction: 4  /nix/store/1i6rasgqkrbmjm6w9vdzsrq8v3w883hw-python-2.7.16/bin/python2.7 nix_run_setup test

@stale
Copy link

@stale stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale label Jun 1, 2020
@bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 25, 2020

Result of nixpkgs-review pr 69128 1

1 package marked as broken and skipped:
- fedpkg

@bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 25, 2020

This ended up just being marked as broken; if you're still interested in the package, feel free to re-open with an updated meta. Closing now to clear out PR backlog.

@bhipple bhipple closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants