Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
makeWrapper: Remove unused extraFlagsArray feature #69370
Motivation for this change
There is a bug in this feature: It allows extra arguments to leak in
Note that you get the man page for
An attempt to fix this was made in 5ae1857 in PR #19328 for
Rather than trying to fix the bug again, we remove the extraFlagsArray
wrapAclocal continues to use its own, separate flavor of extraFlagsArray
There is a bug in this feature: It allows extra arguments to leak in from the environment. For example: $ export extraFlagsArray=date $ man ls Note that you get the man page for date rather than for ls. This happens because 'man' happens to use a wrapper (to add groff to its PATH). An attempt to fix this was made in 5ae1857 in PR #19328 for issue #2537, but 1. That change didn't actually fix the problem because it addressed makeWrapper's environment during the build process, not the constructed wrapper script's environment after installation, and 2. That change was apparently accidentally lost when merged with 7ff6eec. Rather than trying to fix the bug again, we remove the extraFlagsArray feature, since it has never been used in the public repo in the ten years it has been available. wrapAclocal continues to use its own, separate flavor of extraFlagsArray in a more limited context. The analogous bug there was fixed in 4d7d10d in 2011.
Cool, looks like you found a way to proceed. Sorry to cause you some churn.
Yes, it looks like
It looks like your wrappers end up coming out something like:
Thanks for sharing your impact & fix!