Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Erlang OTP to 22.1 #69438

Closed
wants to merge 1 commit into from
Closed

Update Erlang OTP to 22.1 #69438

wants to merge 1 commit into from

Conversation

@hauleth
Copy link
Contributor

hauleth commented Sep 25, 2019

Motivation for this change

Update version to newest Erlang release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @the-kenny @sjmackenzie @couchemar @gleber

@couchemar

This comment has been minimized.

Copy link
Contributor

couchemar commented Sep 27, 2019

Checked on NixOS with nix-review. Also checked Elixir and Erlang binaries

Copy link
Contributor

DianaOlympos left a comment

tested on fedora.

@cw789

This comment has been minimized.

Copy link
Contributor

cw789 commented Oct 14, 2019

Is there anything holding this pull request back?
If so, where could I help?

@cw789 cw789 mentioned this pull request Oct 29, 2019
2 of 10 tasks complete
@cw789 cw789 mentioned this pull request Nov 15, 2019
5 of 10 tasks complete
@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Nov 18, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/70

@cw789

This comment has been minimized.

Copy link
Contributor

cw789 commented Nov 19, 2019

Thanks Łukasz. This PR can be closed now.
I've made a newer one to v22.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.