Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc: compile with DWARF support by default #69552

Merged
merged 1 commit into from Nov 22, 2019
Merged

Conversation

@domenkozar
Copy link
Member

@domenkozar domenkozar commented Sep 26, 2019

This is blocked by https://gitlab.haskell.org/ghc/ghc/issues/17255

Commit

This allows our GHCs to build programs with DWARF debug information
when -g is passed, see https://ghc.haskell.org/trac/ghc/wiki/DWARF.

Compiling with debug symbols is off by default until GHC ticket
https://gitlab.haskell.org/ghc/ghc/issues/15960
(Using -g causes differences in generated core) is fixed.

@ofborg ofborg bot added the 6.topic: haskell label Sep 26, 2019
@ofborg ofborg bot requested review from kosmikus and peti Sep 26, 2019
@domenkozar domenkozar force-pushed the domenkozar:ghc-dwarf branch 2 times, most recently from 5e3b1c5 to 7f8f31a Nov 5, 2019
@domenkozar domenkozar force-pushed the domenkozar:ghc-dwarf branch 2 times, most recently from 33ac5f2 to befc7a4 Nov 19, 2019
This allows our GHCs to build programs with DWARF debug information
when -g is passed, see https://ghc.haskell.org/trac/ghc/wiki/DWARF.

Compiling with debug symbols is off by default until GHC ticket
https://gitlab.haskell.org/ghc/ghc/issues/15960
(Using -g causes differences in generated core) is fixed.
@domenkozar domenkozar force-pushed the domenkozar:ghc-dwarf branch from befc7a4 to 7217090 Nov 20, 2019
@domenkozar domenkozar marked this pull request as ready for review Nov 20, 2019
@domenkozar
Copy link
Member Author

@domenkozar domenkozar commented Nov 20, 2019

@peti this is finally ready, we can only enable dwarf on HEAD for now, as it needs a patch that was merged yesterday.

@domenkozar
Copy link
Member Author

@domenkozar domenkozar commented Nov 21, 2019

@GrahamcOfBorg build haskell.packages.ghcHEAD

@domenkozar
Copy link
Member Author

@domenkozar domenkozar commented Nov 21, 2019

@GrahamcOfBorg build haskell.compiler.ghcHEAD

@domenkozar
Copy link
Member Author

@domenkozar domenkozar commented Nov 22, 2019

It builds locally on linux.

@domenkozar domenkozar merged commit 1b13a8f into NixOS:master Nov 22, 2019
22 checks passed
22 checks passed
haskell.compiler.ghcHEAD on aarch64-linux No attempt
Details
haskell.compiler.ghcHEAD on x86_64-darwin Timed out, unknown build status
Details
haskell.compiler.ghcHEAD on x86_64-linux Timed out, unknown build status
Details
haskell.packages.ghcHEAD on aarch64-linux No attempt
Details
haskell.packages.ghcHEAD on x86_64-darwin No attempt
Details
haskell.packages.ghcHEAD on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
ghc on aarch64-linux Success
Details
ghc on x86_64-darwin Success
Details
ghc on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@nixos-discourse

This comment has been minimized.

Copy link

@nixos-discourse nixos-discourse commented on 7217090 Apr 12, 2020

This commit has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/ghc-with-libdw-support/6654/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.