Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

units: Add units_cur python script to $out #69843

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@doronbehar
Copy link
Contributor

doronbehar commented Sep 28, 2019

Motivation for this change

The GNU package units provides a Python script named units_cur which is not installed by default using make install. This change adds that file to the package's $out. It is possible to configure the pythonPackages set which will be used for the only Python dependency which is requests.

Things done

I've changed the default units package to include the Python script by default in pkgs/top-level/all-packages.nix because I think that's the author's intention.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vrthra

@ofborg ofborg bot requested a review from vrthra Sep 28, 2019
@doronbehar doronbehar mentioned this pull request Oct 3, 2019
6 of 10 tasks complete
@bjornfor

This comment has been minimized.

Copy link
Contributor

bjornfor commented Oct 6, 2019

Have you talked to upstream about why this script isn't installed by them?

@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Oct 7, 2019

AFAIK, upstream doesn't have a bug reports webpage or a GitHub repo or anything like that, they don't even use a VCS. I once talked with the developer directly through with email and he was responsive but I don't think this issue is such a big deal that we should send him a patch making Makefile.am install this script.

I wouldn't mind that much doing it but I'm not experienced with GNU autotools so I don't think it's worth the effort.

@matthewbauer matthewbauer merged commit ba20555 into NixOS:master Nov 7, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.