Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc : improved and cleanup of submitting-changes #70208

Merged
merged 2 commits into from Jan 10, 2020

Conversation

@mrVanDalo
Copy link
Contributor

@mrVanDalo mrVanDalo commented Oct 1, 2019

Motivation for this change

Some documentation refactoring

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

I don't know

cc @

@mrVanDalo mrVanDalo force-pushed the mrVanDalo:feature/pull-request-workflow branch from 6d9ece5 to 1a685f4 Oct 1, 2019
@mrVanDalo mrVanDalo changed the title Feature/pull request workflow doc/submitting-changes : improved and cleanup of section 15 Oct 1, 2019
@mrVanDalo mrVanDalo changed the title doc/submitting-changes : improved and cleanup of section 15 doc : improved and cleanup of submitting-changes Oct 1, 2019
@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Oct 2, 2019

Related to: NixOS/rfcs#53

</listitem>
<listitem>
<para>
Notify maintainers of the package. For example add to the message: <command>cc @jagajaga @domenkozar</command>.

This comment has been minimized.

@7c6f434c

7c6f434c Oct 2, 2019
Member

If you edit an existing package, ofBorg will notify the maintainers automatically, so maybe drop that?

This comment has been minimized.

@mrVanDalo

mrVanDalo Oct 2, 2019
Author Contributor

not yet. right @Lassulus ?

This comment has been minimized.

@Lassulus

Lassulus Oct 2, 2019
Contributor

I think only the maintainer which are part of the organization. I'm not sure if this includes everyone by now?

This comment has been minimized.

@mrVanDalo

mrVanDalo Oct 2, 2019
Author Contributor

Also the cc part is still in the template. I looked at some pull-requests and it seems that ofBorg adds reviewers, but not all maintainers.

This comment has been minimized.

@7c6f434c

7c6f434c Oct 2, 2019
Member

Asked in NixOS/rfcs#39 — it looks like vast majority of maintainers are currently indeed organisation members (via readonly maintainers team) and can be review-requested. If every maintainer has already been invited, we could drop the cc line in template too, I guess.

This comment has been minimized.

@mrVanDalo

mrVanDalo Oct 2, 2019
Author Contributor

So I wouldn't do it now. I'll come back to it in another pull-request.

This comment has been minimized.

@7c6f434c

7c6f434c Jan 2, 2020
Member

I think NixOS/rfcs#39 has been now implemented as well as it can be…

This comment has been minimized.

@mrVanDalo

mrVanDalo Jan 2, 2020
Author Contributor

removed the line from this pull-request. I don't have the privileges to change the pull-request template. @Mic92 @Lassulus ?

doc/submitting-changes.xml Outdated Show resolved Hide resolved
@mrVanDalo mrVanDalo force-pushed the mrVanDalo:feature/pull-request-workflow branch from d30eadb to 5b7ca8c Oct 2, 2019
@mrVanDalo
Copy link
Contributor Author

@mrVanDalo mrVanDalo commented Oct 2, 2019

@alyssais all done.

@mrVanDalo mrVanDalo requested a review from alyssais Oct 2, 2019
@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Dec 30, 2019

needs rebase

@mrVanDalo mrVanDalo force-pushed the mrVanDalo:feature/pull-request-workflow branch from 5b7ca8c to 34f0e5e Jan 1, 2020
@mrVanDalo
Copy link
Contributor Author

@mrVanDalo mrVanDalo commented Jan 1, 2020

@Lassulus done

@mrVanDalo mrVanDalo force-pushed the mrVanDalo:feature/pull-request-workflow branch from 34f0e5e to 9d9fa91 Jan 2, 2020
@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Jan 2, 2020

mrVanDalo added 2 commits Jan 3, 2020
@mrVanDalo mrVanDalo force-pushed the mrVanDalo:feature/pull-request-workflow branch from 9d9fa91 to d9bbc22 Jan 3, 2020
@mrVanDalo
Copy link
Contributor Author

@mrVanDalo mrVanDalo commented Jan 3, 2020

@7c6f434c done

removed the line from this pull-request. I don't have the privileges to change the pull-request template. @Mic92 @Lassulus ?
Well, you can add a change to <nixpkgs>/.github/PULL_REQUEST_TEMPLATE.md to the PR

@Lassulus Lassulus merged commit 773494d into NixOS:master Jan 10, 2020
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.