Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: add support for python_script component #70258

Merged
merged 2 commits into from Jan 9, 2020

Conversation

@juaningan
Copy link
Contributor

@juaningan juaningan commented Oct 2, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dotlambda

Copy link
Contributor

@jonringer jonringer left a comment

Is the commit history messed up? looks like your first commit tries to add the package that doesnt exist yet

@juaningan
Copy link
Contributor Author

@juaningan juaningan commented Nov 7, 2019

I make the package and run parse_requirements.py locally both, and then make 2 commits. The result is ok. Then only mess is now, rerunning parse_requirementes.py add python-vlc. I think somebody forget to run it in another PR.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 7, 2019

hmm, very possible

@juaningan juaningan force-pushed the juaningan:restrictedpython branch from 5d03d49 to 421bd72 Nov 12, 2019
juaningan added 2 commits Oct 2, 2019
home-assistant: run parse-requirements.py
@juaningan juaningan force-pushed the juaningan:restrictedpython branch from 421bd72 to 3f860eb Nov 16, 2019
@juaningan
Copy link
Contributor Author

@juaningan juaningan commented Dec 3, 2019

Is there something I can do to merge this?

@jonringer jonringer mentioned this pull request Dec 20, 2019
3 of 10 tasks complete
@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Jan 9, 2020

Looks good!

@peterhoeg peterhoeg merged commit 0cffec3 into NixOS:master Jan 9, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
home-assistant on aarch64-linux Success
Details
home-assistant on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.