Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu: apply patch for CVE-2019-13164 [19.09] #70269

Closed
wants to merge 1 commit into from

Conversation

@delroth
Copy link
Contributor

delroth commented Oct 2, 2019

Motivation for this change

#70124 (security fix)

master is on 4.1.0 which already has this fixed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@delroth delroth force-pushed the delroth:qemu-cve-19.09 branch from 70ad1c1 to 6d1107f Oct 2, 2019
@ofborg ofborg bot requested a review from edolstra Oct 2, 2019
Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
executables still seem to work

[23 built, 229 copied (1639.5 MiB), 355.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70269
18 package were build:
aqemu cloud-init cloud-utils libguestfs libguestfs-with-appliance memtest86-efi minikube out-of-tree python27Packages.guestfs python37Packages.guestfs qemu qemu_kvm qemu_test qemu_xen qemu_xen-light qemu_xen_4_10 qemu_xen_4_10-light vagrant
@ckauhaus

This comment has been minimized.

Copy link
Contributor

ckauhaus commented Oct 30, 2019

@delroth Sorry that merging this PR somehow got stuck. Would you please be so kind a check two points:

  1. In the meantime, we have an update to 4.0.1 in #72236. Is the patch still relevant at all?
  2. There are merge conflicts with current release-19.09. Could you resolve them?

Thank you!

@ckauhaus ckauhaus mentioned this pull request Oct 30, 2019
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.