Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gaia: init at 2.4.5 #70372

Merged
merged 8 commits into from Nov 7, 2019
Merged

gaia: init at 2.4.5 #70372

merged 8 commits into from Nov 7, 2019

Conversation

@doronbehar
Copy link
Contributor

doronbehar commented Oct 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@doronbehar doronbehar requested a review from FRidh as a code owner Oct 5, 2019
Copy link
Contributor Author

doronbehar left a comment

Thanks for all the comments @aszlig, I've commented as well and pushed changes.

@ofborg ofborg bot added the 6.topic: python label Oct 5, 2019
Use pythonPackages instead of just python and add an attribute to
python-packages.nix.
@doronbehar doronbehar force-pushed the doronbehar:package-gaia branch from fbfd277 to a246b74 Oct 5, 2019
Copy link
Contributor Author

doronbehar left a comment

Thanks @aszlig for the comments, I've pushed a working build including a disable for Python3.

substituteInPlace src/wscript \
--replace "/etc/cyclops" "$out/etc/cyclops" \
--replace "/etc/init.d" "$out/etc/init.d"
'';

This comment has been minimized.

Copy link
@doronbehar

doronbehar Oct 8, 2019

Author Contributor

BTW @aszlig, what do you think about the fact the package installs init.d files? I've had a look at these files today and I noticed they refer to paths which rely upon the fact the system will comply to the FHS hierarchy. Patching them might require some work. I wouldn't mind dive into it but NixOS doesn't even use these init files so what would be the point of that? Should we provide systemd files that will provide the same functionality? TBH I don't even know what these daemons are for and I've never used them not I intend to. Maybe we can keep it as is so future users of this package will be able to look at them for reference?

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Oct 21, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/71

@matthewbauer matthewbauer merged commit 5dfbfc0 into NixOS:master Nov 7, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 8, 2019

Thanks @matthewbauer! Now that this is merged, could you please take a look at #70389?

dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
gaia: init at 2.4.5
(cherry picked from commit 5dfbfc0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.