Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdcat: init at 0.13.0 #70388

Merged
merged 2 commits into from Oct 5, 2019

Conversation

@davidtwco
Copy link
Contributor

commented Oct 4, 2019

Motivation for this change

Adds a package for mdcat (and ansi2html for mdcat's testing).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

me!

@davidtwco davidtwco requested a review from FRidh as a code owner Oct 4, 2019
@ofborg ofborg bot added the 6.topic: python label Oct 4, 2019
@teto

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

@GrahamcOfBorg build mdcat

@teto

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

tested and working. Before merging, could you split the python package in a separate commit please ?

davidtwco added 2 commits Oct 5, 2019
@davidtwco davidtwco force-pushed the davidtwco:mdcat-init branch from 54beb70 to 7500c71 Oct 5, 2019
@davidtwco

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2019

tested and working. Before merging, could you split the python package in a separate commit please ?

Done, thanks!

@teto

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

@GrahamcOfBorg build mdcat

@teto teto merged commit e3c3b5f into NixOS:master Oct 5, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mdcat on aarch64-linux Success
Details
mdcat on x86_64-darwin Success
Details
mdcat on x86_64-linux Success
Details
@teto

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

thanks

@davidtwco davidtwco deleted the davidtwco:mdcat-init branch Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.