Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cocoapods: 1.8.1 -> 1.8.4 #70417

Merged
merged 2 commits into from Nov 7, 2019

Conversation

@lilyball
Copy link
Member

lilyball commented Oct 4, 2019

Motivation for this change

https://github.com/CocoaPods/CocoaPods/releases/tag/1.8.3
https://github.com/CocoaPods/CocoaPods/releases/tag/1.8.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lilyball lilyball changed the title Cocoapods cocoapods: 1.8.1 -> 1.8.3 Oct 19, 2019
@lilyball lilyball force-pushed the lilyball:cocoapods branch from 1f569d9 to 8c15284 Oct 19, 2019
@lilyball lilyball changed the title cocoapods: 1.8.1 -> 1.8.3 cocoapods: 1.8.1 -> 1.8.4 Oct 19, 2019
@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Oct 19, 2019

@GrahamcOfBorg build cocoapods cocoapods-beta

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Nov 6, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/75

@marsam marsam merged commit f2ecbaa into NixOS:master Nov 7, 2019
16 checks passed
16 checks passed
cocoapods, cocoapods-beta on aarch64-linux No attempt
Details
cocoapods, cocoapods-beta on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
cocoapods, cocoapods-beta on x86_64-darwin Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@marsam

This comment has been minimized.

Copy link
Contributor

marsam commented Nov 7, 2019

Thanks!

@lilyball lilyball deleted the lilyball:cocoapods branch Nov 7, 2019
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
cocoapods: 1.8.1 -> 1.8.4
(cherry picked from commit f2ecbaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.