Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argbash: init at 2.8.1 #70489

Merged
merged 3 commits into from Nov 7, 2019
Merged

argbash: init at 2.8.1 #70489

merged 3 commits into from Nov 7, 2019

Conversation

@rencire
Copy link
Contributor

rencire commented Oct 5, 2019

Motivation for this change

Add new package: argbash

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

{ stdenv, fetchFromGitHub, autoconf }:

stdenv.mkDerivation rec {
name = "argbash";

This comment has been minimized.

Copy link
@mmahut

mmahut Oct 5, 2019

Member

Please use pname.

This comment has been minimized.

Copy link
@rencire

rencire Oct 5, 2019

Author Contributor

oops, thanks!

@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Oct 5, 2019

@GrahamcOfBorg build argbash

@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Oct 6, 2019

@GrahamcOfBorg build argbash

Copy link
Member

nlewo left a comment

It seems you need to update the hash since it fails on ofBorg. Maybe you already have a derivation with this hash in your cache.

sha256 = "0jzfr2w5pza33mvw6hq6rm1vjgrfy95dp4421403jnji3ziwgf0w";
};

sourceRoot = "${src}/resources";

This comment has been minimized.

Copy link
@nlewo

nlewo Oct 10, 2019

Member

minor: i think a relative path is sufficient

This comment has been minimized.

Copy link
@rencire

rencire Oct 25, 2019

Author Contributor

Tried ./resources and resources and it didn't work. Seems like ${src} is required?

@rencire rencire requested a review from nlewo Nov 3, 2019
@matthewbauer matthewbauer merged commit 5dc0c77 into NixOS:master Nov 7, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
* argbash: init at 2.8.1

* changed name to pname

* updated sha256 hash

(cherry picked from commit 5dc0c77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.