Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renoise version 3.2.0 #70534

Merged
merged 1 commit into from Dec 13, 2019
Merged

Renoise version 3.2.0 #70534

merged 1 commit into from Dec 13, 2019

Conversation

@timothee-haudebourg
Copy link
Contributor

@timothee-haudebourg timothee-haudebourg commented Oct 6, 2019

renoise: 3.1.0 -> 3.2.0

Motivation for this change

New version of Renoise. Previous version is not even downloadable anymore, which makes this derivation fail (until now). Also, 32-bits platform is not supported by Renoise anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of the Demo version.
  • Tested execution of the Full version (I don't own the Full version). However nothing should have changed since 3.1.0.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
Notify maintainers

There are no maintainers, and I don't intend to become one until I buy the full version of Renoise.

sha256 = "0pan68fr22xbj7a930y29527vpry3f07q3i9ya4fp6g7aawffsga";
}
fetchurl {
url = "https://files.renoise.com/demo/Renoise_${urlVersion version}_Demo_Linux.tar.gz";

This comment has been minimized.

@wucke13

wucke13 Oct 8, 2019
Contributor

I would consider changing
this to

urls = [
  "https://files.renoise.com/demo/Renoise_${urlVersion version}_Demo_Linux.tar.gz"
  "https://web.archive.org/web/https://files.renoise.com/demo/Renoise_${urlVersion version}_Demo_Linux.tar.gz"
];

That way the download may work even if the original link becomes invalid.

This comment has been minimized.

@timothee-haudebourg

timothee-haudebourg Oct 16, 2019
Author Contributor

Good idea. Done.

@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Dec 8, 2019

can you squash the commits and make the commit message say: "renoise: 3.1.0 -> 3.2.0" ?

@timothee-haudebourg timothee-haudebourg force-pushed the timothee-haudebourg:renoise_3.2.0 branch from 7a9704f to 5ec5a74 Dec 13, 2019
@timothee-haudebourg
Copy link
Contributor Author

@timothee-haudebourg timothee-haudebourg commented Dec 13, 2019

@Lassulus done.

Copy link
Contributor

@Lassulus Lassulus left a comment

tested with nix-review

@Lassulus Lassulus merged commit 6005fb0 into NixOS:master Dec 13, 2019
15 checks passed
15 checks passed
renoise on aarch64-linux No attempt
Details
renoise on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.