Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glfw: 3.2.1 -> 3.3 #70626

Merged
merged 1 commit into from Nov 7, 2019
Merged

glfw: 3.2.1 -> 3.3 #70626

merged 1 commit into from Nov 7, 2019

Conversation

@Twey
Copy link
Contributor

Twey commented Oct 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @MarcWeber

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM

[18 built, 71 copied (717.9 MiB), 87.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70626
11 package were build:
ccextractor embree2 glfw glslviewer goxel idrisPackages.glfw io kitty luxcorerender vcv-rack vlang
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Oct 8, 2019

@GrahamcOfBorg build glfw

@Marqin

This comment has been minimized.

Copy link

Marqin commented Oct 8, 2019

@jonringer any ETA when this will land?

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Oct 8, 2019

I just want to give some time for other maintainers to comment. I'm not super familiar with glfw

@Moredread

This comment has been minimized.

Copy link
Contributor

Moredread commented Oct 16, 2019

vcv-rack overrides the glfw version, so this shouldn't cause a problem there. We might be able to switch to upstream again after this merges though.

@k0ral

This comment has been minimized.

Copy link
Contributor

k0ral commented Nov 7, 2019

I was about to contribute the same change when I noticed this pull-request.
Given that it's been open for a month now, with no reservations from reviewers, would-you-kindly consider merging it ? :)

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 7, 2019

really wish there was a !remindme 2 days functionality... too many PRs xD

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM

[26 built, 345 copied (4920.8 MiB), 787.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70626
11 package were build:
ccextractor embree2 glfw glslviewer goxel idrisPackages.glfw io kitty luxcorerender vcv-rack vlang

sorry for the long delay! :(

@jonringer jonringer merged commit 5f6f75f into NixOS:master Nov 7, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
glfw on aarch64-linux Success
Details
glfw on x86_64-darwin Success
Details
glfw on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.