Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octave: build with gl2ps #70772

Merged
merged 2 commits into from Dec 13, 2019
Merged

octave: build with gl2ps #70772

merged 2 commits into from Dec 13, 2019

Conversation

@tmplt
Copy link
Contributor

@tmplt tmplt commented Oct 8, 2019

Motivation for this change

Resolves #38459

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @raskin

Resolves #38459
@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Oct 9, 2019

@GrahamcOfBorg build octave octaveFull

@tmplt
Copy link
Contributor Author

@tmplt tmplt commented Oct 20, 2019

Is anything blocking this PR or can it be merged?

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Oct 21, 2019

As is it seems to make octave marked as broken. Am I missing something in the ofBorg report?

@tmplt
Copy link
Contributor Author

@tmplt tmplt commented Oct 21, 2019

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Oct 21, 2019

@tmplt Expand the list — there are three neutral checks, and if you look into details, you see that the attributes are not built because the evaluation complains there is a broken dependency.

@tmplt
Copy link
Contributor Author

@tmplt tmplt commented Oct 30, 2019

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Oct 30, 2019

@tmplt
Copy link
Contributor Author

@tmplt tmplt commented Nov 14, 2019

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Nov 14, 2019

@GrahamcOfBorg build octave octaveFull

@tmplt
Copy link
Contributor Author

@tmplt tmplt commented Nov 15, 2019

Jotting down for later: darwin fails because qt4 is no longer supported on that platform; I don't get why aarch64 fails with Package ‘octave-5.1.0’ in [...] is not supported on ‘aarch64-linux’, refusing to evaluate., because platforms = linux ++ darwin.

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Dec 8, 2019

@ofborg build octave octaveFull

@7c6f434c 7c6f434c merged commit dd3ddb3 into NixOS:master Dec 13, 2019
21 checks passed
21 checks passed
build, octave, octaveFull on x86_64-darwin No attempt
Details
octave, octaveFull on x86_64-darwin No attempt
Details
octave, octaveFull on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
build, octave, octaveFull on aarch64-linux Success
Details
build, octave, octaveFull on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
octave on aarch64-linux Success
Details
octave on x86_64-linux Success
Details
octave, octaveFull on aarch64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.