Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srt-vtt: init at 2019-01-03 #70885

Merged
merged 5 commits into from Nov 7, 2019
Merged

Conversation

@ericdallo
Copy link
Contributor

ericdallo commented Oct 9, 2019

Motivation for this change

Add srt-vtt command

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Oct 10, 2019

@GrahamcOfBorg build srt-to-vtt-cl

@ericdallo ericdallo force-pushed the ericdallo:add-srt-to-vtt-cl branch from 3ef76ff to 93bbd8c Oct 10, 2019
@ericdallo ericdallo requested a review from mmahut Oct 10, 2019
@ericdallo ericdallo changed the title srt-vtt: init at 1.2.0 srt-vtt: init at 2019-01-03 Oct 10, 2019
@ericdallo ericdallo force-pushed the ericdallo:add-srt-to-vtt-cl branch from 93bbd8c to 4475750 Oct 10, 2019
Co-Authored-By: Marek Mahut <marek.mahut@gmail.com>
@ericdallo ericdallo requested a review from mmahut Oct 11, 2019
@ericdallo

This comment has been minimized.

Copy link
Contributor Author

ericdallo commented Oct 18, 2019

@mmahut can you review again please?

ericdallo added 2 commits Oct 21, 2019
@ericdallo

This comment has been minimized.

Copy link
Contributor Author

ericdallo commented Oct 21, 2019

@Evils-Devils or @charles-dyfis-net can you review it again please?

@Evils-Devils

This comment has been minimized.

Copy link
Contributor

Evils-Devils commented Oct 22, 2019

BTW, it looks like there's tests available in the source, but one fails, are you sure this tool is working correctly? (seems to work for me but i just ran it once)
("/bin/bash" will also have to be replaced if you intend to use those tests, but building will fail if the test fails)

@ericdallo

This comment has been minimized.

Copy link
Contributor Author

ericdallo commented Oct 22, 2019

For me its working very well, I didn't know there are tests for these... I'll try to change /bin/bash to check if tests pass.

Co-Authored-By: Evils-Devils <30512529+Evils-Devils@users.noreply.github.com>
@matthewbauer matthewbauer merged commit ccc13c2 into NixOS:master Nov 7, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
* srt-vtt: init at 2019-01-03

* Append 'unstable' to pname

Co-Authored-By: Marek Mahut <marek.mahut@gmail.com>

* Fix version

* Remove which validation

* Add support to linux only

Co-Authored-By: Evils-Devils <30512529+Evils-Devils@users.noreply.github.com>
(cherry picked from commit ccc13c2)
@ericdallo ericdallo deleted the ericdallo:add-srt-to-vtt-cl branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.