Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add documentation for the new option to the Automatic Upgrades section #70887

Merged
merged 1 commit into from Feb 8, 2020

Conversation

@tokudan
Copy link
Contributor

@tokudan tokudan commented Oct 9, 2019

Motivation for this change

Add information to the release notes for 19.09
Backport to 19.09: #71056

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@tokudan
Copy link
Contributor Author

@tokudan tokudan commented Oct 12, 2019

I added the allowReboot option to the documentation as well

@tokudan tokudan changed the title Update to PR #64267, add missing release notes. Update to PR #64267, add missing release notes and documentation Oct 12, 2019
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Dec 23, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/13

@tokudan
Copy link
Contributor Author

@tokudan tokudan commented Feb 6, 2020

@worldofpeace @disassembler This one's probably for you, should I move this update for the release notes of 19.09 into 20.03?

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 6, 2020

@tokudan Did the change get introduced in 19.09 but go unannounced? I guess it wouldn't be correct to add a release note posthumously, but the documentation update is fine.

…ection
@tokudan tokudan force-pushed the tokudan:autoUpgrade.allowReboot-rn branch from a223335 to 7322058 Feb 8, 2020
@tokudan
Copy link
Contributor Author

@tokudan tokudan commented Feb 8, 2020

Removed the release notes and just left the documentation

@worldofpeace worldofpeace changed the title Update to PR #64267, add missing release notes and documentation doc: Add documentation for the new option to the Automatic Upgrades section Feb 8, 2020
@worldofpeace worldofpeace merged commit 4befcf4 into NixOS:master Feb 8, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 8, 2020
 doc: Add documentation for the new option to the Automatic Upgrades section

(cherry picked from commit 4befcf4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.