Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alot: fix hardcoded Python in Zsh completion #70903

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@minijackson
Copy link
Contributor

minijackson commented Oct 10, 2019

Motivation for this change

This allows completing alot compose --sender <Tab>

I would have liked to have a solution similar to wrapPython instead of having a python with custom env (this adds another derivation to the mix), but I couldn't see how to extract the preamble.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nix-review 1

1 package were build:
  • alot
Notify maintainers

cc @geistesk

@minijackson minijackson requested a review from FRidh as a code owner Oct 10, 2019
@ofborg ofborg bot added the 6.topic: python label Oct 10, 2019
@ofborg ofborg bot requested a review from geistesk Oct 10, 2019
@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Oct 10, 2019

@teto

This comment has been minimized.

Copy link
Contributor

teto commented Oct 11, 2019

Not sure yet how to properly fix this but yeah this feels wrong.

This allows completing `alot compose --sender <Tab>`
@minijackson minijackson force-pushed the minijackson:fix-alot-completion branch from c3d732b to 8dc4c39 Oct 11, 2019
@minijackson minijackson requested a review from FRidh Nov 1, 2019
@matthewbauer matthewbauer merged commit 561edb9 into NixOS:master Nov 7, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@minijackson minijackson deleted the minijackson:fix-alot-completion branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.