Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonobuoy: 0.15.0 -> 0.16.1 #70904

Merged
merged 1 commit into from Nov 22, 2019
Merged

sonobuoy: 0.15.0 -> 0.16.1 #70904

merged 1 commit into from Nov 22, 2019

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Oct 10, 2019

Motivation for this change

Update sonobuoy to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@saschagrunert
Copy link
Member Author

@saschagrunert saschagrunert commented Oct 10, 2019

@saschagrunert
Copy link
Member Author

@saschagrunert saschagrunert commented Oct 10, 2019

@GrahamcOfBorg build sonobuoy

@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 11, 2019

@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 21, 2019

Some context about the change of repo:
https://sonobuoy.io/new-github-org/

Copy link
Contributor

@c0bw3b c0bw3b left a comment

Commit message should read 0.15.0 -> 0.16.1 and not 1.15.0 -> 1.16.1
+ upstream is now at 0.16.4

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert force-pushed the saschagrunert:sonobuoy branch from 942649e to c1d22b4 Nov 22, 2019
@saschagrunert saschagrunert changed the title sonobuoy: 1.15.0 -> 1.16.1 sonobuoy: 0.15.0 -> 0.16.1 Nov 22, 2019
@saschagrunert
Copy link
Member Author

@saschagrunert saschagrunert commented Nov 22, 2019

Commit message should read 0.15.0 -> 0.16.1 and not 1.15.0 -> 1.16.1

  • upstream is now at 0.16.4

Ah yes, fixed that as well :) Thanks for the review

@ofborg ofborg bot requested review from carlosdagos and ehmry Nov 22, 2019
@c0bw3b
c0bw3b approved these changes Nov 22, 2019
@c0bw3b c0bw3b merged commit 801da15 into NixOS:master Nov 22, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sonobuoy on aarch64-linux Success
Details
sonobuoy on x86_64-linux Success
Details
@saschagrunert saschagrunert deleted the saschagrunert:sonobuoy branch Nov 22, 2019
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
(cherry picked from commit 801da15)
@wilsonehusin wilsonehusin mentioned this pull request Oct 15, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.