Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mariadb: remove development components #70924

Merged
merged 4 commits into from Nov 15, 2019
Merged

Conversation

@Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Oct 10, 2019

Motivation for this change

Remove development components. Need to use only libmysqlclient package.
Update build configuration.

Please recheck build configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from thoughtpolice Oct 10, 2019
@Izorkin Izorkin force-pushed the Izorkin:mariadb-remove-dev branch 2 times, most recently from 2e26f81 to 886077d Oct 10, 2019
@ofborg ofborg bot requested a review from peterhoeg Oct 10, 2019
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Oct 11, 2019

@GrahamcOfBorg build zoneminder

@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Oct 11, 2019

@GrahamcOfBorg build perlPackages.SysCPU

@volth
Copy link
Contributor

@volth volth commented Oct 18, 2019

SysCPU

There is a bugfix for aarch64: #64748 (comment)

@Izorkin Izorkin force-pushed the Izorkin:mariadb-remove-dev branch from b6b3cae to 9738e06 Oct 18, 2019
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Oct 18, 2019

@GrahamcOfBorg build perlPackages.SysCPU

@Izorkin Izorkin force-pushed the Izorkin:mariadb-remove-dev branch from 9738e06 to dffe648 Oct 18, 2019
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Oct 18, 2019

@volth thanks, added patch.

@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Oct 18, 2019

@GrahamcOfBorg build perlPackages.SysCPU

pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
@volth
Copy link
Contributor

@volth volth commented Oct 23, 2019

@Izorkin Izorkin force-pushed the Izorkin:mariadb-remove-dev branch from dffe648 to 4bee6dd Oct 23, 2019
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Oct 23, 2019

Use fetchpatch or doCheck ?

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Oct 23, 2019

If tests work fine after applying patches, we can drop doCheck.
The staging patch should be reverted however.

@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Oct 23, 2019

@GrahamcOfBorg build perlPackages.SysCPU

@Izorkin Izorkin force-pushed the Izorkin:mariadb-remove-dev branch from 4bee6dd to cfde67c Oct 24, 2019
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Oct 24, 2019

@GrahamcOfBorg build perlPackages.SysCPU

@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Oct 24, 2019

@GrahamcOfBorg build mariadb zoneminder

@aanderse aanderse requested a review from jonringer Oct 30, 2019
@Izorkin Izorkin force-pushed the Izorkin:mariadb-remove-dev branch from cfde67c to 7702d28 Nov 6, 2019
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Nov 6, 2019

Update Mariadb to version 10.3.19

@Izorkin Izorkin force-pushed the Izorkin:mariadb-remove-dev branch from dbc870a to 67d80e5 Nov 7, 2019
@Izorkin Izorkin changed the title mariadb: remove development components mariadb: 10.3.18 -> 10.3.19 and remove development components Nov 7, 2019
@Izorkin Izorkin changed the title mariadb: 10.3.18 -> 10.3.19 and remove development components mariadb: remove development components Nov 7, 2019
@Izorkin Izorkin force-pushed the Izorkin:mariadb-remove-dev branch 2 times, most recently from f308b97 to ee42b6d Nov 7, 2019
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Nov 9, 2019

Update package to version 10.3.20

сс @thoughtpolice @matthewbauer @Mic92

@Izorkin Izorkin mentioned this pull request Nov 12, 2019
3 of 10 tasks complete
@Izorkin Izorkin force-pushed the Izorkin:mariadb-remove-dev branch from ee42b6d to 144735a Nov 15, 2019
@Mic92 Mic92 merged commit 3102738 into NixOS:master Nov 15, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mariadb, zoneminder on aarch64-linux Success
Details
mariadb, zoneminder on x86_64-darwin Success
Details
mariadb, zoneminder on x86_64-linux Success
Details
@Izorkin Izorkin deleted the Izorkin:mariadb-remove-dev branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.