Skip to content

riot-{web,desktop}: 1.4.1 -> 1.4.2 #70970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2019
Merged

riot-{web,desktop}: 1.4.1 -> 1.4.2 #70970

merged 2 commits into from
Oct 12, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Oct 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@pacien
Copy link
Contributor Author

pacien commented Oct 11, 2019

This should probably be backported to 19.09 as there's a critical bug (blank screen) in Riot 1.4.1.

@ofborg ofborg bot requested a review from worldofpeace October 11, 2019 12:26
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 11, 2019
@Ma27 Ma27 self-requested a review October 11, 2019 21:16
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 12, 2019
@Ma27 Ma27 merged commit f91a973 into NixOS:master Oct 12, 2019
@Ma27
Copy link
Member

Ma27 commented Oct 12, 2019

Thanks! Backported as d908ad4, 661beaa.

@Ma27 Ma27 added 8.has: port to stable This PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacien @Ma27