Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox, firefox-bin: 69.0.2 -> 69.0.3 #70976

wants to merge 2 commits into from


Copy link

@taku0 taku0 commented Oct 11, 2019

Motivation for this change
  • Bug fixes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits

Tested only firefox-bin.

Notify maintainers

cc @edolstra @andir

Copy link
Contributor Author

@taku0 taku0 commented Oct 11, 2019

Cannot compile firefox with the following error.

error[E0506]: cannot assign to `self.input.cached_token` because it is borrowed
   --> /build/firefox-68.1.0/third_party/rust/cssparser/src/
559 |     pub fn next_including_whitespace_and_comments(&mut self) -> Result<&Token<'i>, BasicParseError<'i>> {
    |                                                   - let's call the lifetime of this reference `'1`
572 |             Some(ref cached_token)
    |                  ---------------- borrow of `self.input.cached_token` occurs here
584 |                 self.input.cached_token = Some(CachedToken {
    |                 ^^^^^^^^^^^^^^^^^^^^^^^ assignment to borrowed `self.input.cached_token` occurs here
596 |         Ok(token)
    |         --------- returning this value requires that `self.input.cached_token.0` is borrowed for `'1`

Maybe related:
#70735 (comment)

@taku0 taku0 closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.