Skip to content

sshping: init at 0.1.4 #71019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2019
Merged

sshping: init at 0.1.4 #71019

merged 2 commits into from
Nov 7, 2019

Conversation

jqueiroz
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 12, 2019

src = fetchFromGitHub {
owner = "spook";
repo = "sshping";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo = "sshping";
repo = name;

Copy link
Member Author

@jqueiroz jqueiroz Oct 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it would be clearer.

'';

meta = with stdenv.lib; {
homepage = https://github.com/spook/sshping;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://github.com/spook/sshping;
homepage = "https://github.com/spook/sshping";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

buildInputs = [ libssh ];

buildPhase = ''
g++ -Wall -I ext/ -o bin/sshping src/sshping.cxx -lssh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use the upstream's Makefile?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream Makefile has a hardcoded path for libssh.h (/usr/include/libssh/libssh.h). Since the build a single command, I think it's slightly simpler to have it here than it would be to fix the Makefile.

@mmahut
Copy link
Member

mmahut commented Oct 16, 2019

@GrahamcOfBorg build sshping

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 22, 2019
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 22, 2019
@matthewbauer matthewbauer merged commit 495f4ee into NixOS:master Nov 7, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
sshping: init at 0.1.4
(cherry picked from commit 495f4ee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants