Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sshping: init at 0.1.4 #71019

Merged
merged 2 commits into from Nov 7, 2019
Merged

sshping: init at 0.1.4 #71019

merged 2 commits into from Nov 7, 2019

Conversation

@jqueiroz
Copy link
Contributor

jqueiroz commented Oct 12, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

src = fetchFromGitHub {
owner = "spook";
repo = "sshping";

This comment has been minimized.

Copy link
@mmahut

mmahut Oct 16, 2019

Member
Suggested change
repo = "sshping";
repo = name;

This comment has been minimized.

Copy link
@jqueiroz

jqueiroz Oct 22, 2019

Author Contributor

Not sure it would be clearer.

'';

meta = with stdenv.lib; {
homepage = https://github.com/spook/sshping;

This comment has been minimized.

Copy link
@mmahut

mmahut Oct 16, 2019

Member
Suggested change
homepage = https://github.com/spook/sshping;
homepage = "https://github.com/spook/sshping";

This comment has been minimized.

Copy link
@jqueiroz

jqueiroz Oct 22, 2019

Author Contributor

Fixed, thanks!

buildInputs = [ libssh ];

buildPhase = ''
g++ -Wall -I ext/ -o bin/sshping src/sshping.cxx -lssh

This comment has been minimized.

Copy link
@mmahut

mmahut Oct 16, 2019

Member

Why not to use the upstream's Makefile?

This comment has been minimized.

Copy link
@jqueiroz

jqueiroz Oct 22, 2019

Author Contributor

The upstream Makefile has a hardcoded path for libssh.h (/usr/include/libssh/libssh.h). Since the build a single command, I think it's slightly simpler to have it here than it would be to fix the Makefile.

@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Oct 16, 2019

@GrahamcOfBorg build sshping

@jqueiroz jqueiroz force-pushed the jqueiroz:jqueiroz/sshping branch from 7f18a14 to 42738db Oct 22, 2019
@matthewbauer matthewbauer merged commit 495f4ee into NixOS:master Nov 7, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
sshping: init at 0.1.4
(cherry picked from commit 495f4ee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.