Skip to content

poppler: add patch for CVE-2019-9959 #71046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2019
Merged

poppler: add patch for CVE-2019-9959 #71046

merged 1 commit into from
Oct 13, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 12, 2019 •
edited
Loading

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-9959

For the main poppler package, we should be looking at merging #60701.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle risicle force-pushed the ris-poppler-CVE-2019-9959 branch from 9858d08 to 2d09ae0 Compare October 12, 2019 17:55
@risicle risicle changed the base branch from release-19.09 to staging-19.09 October 12, 2019 17:56
@risicle
Copy link
Contributor Author

risicle commented Oct 12, 2019

Rebased to staging because of huge rebuild.

@ofborg ofborg bot requested a review from ttuegel October 12, 2019 18:01
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux. labels Oct 12, 2019
@ofborg ofborg bot requested review from lovek323 and edolstra October 12, 2019 18:11
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 12, 2019
@veprbl
Copy link
Member

veprbl commented Oct 12, 2019

#60701 is not ready. It makes sense to apply this to master as well instead of rushing an upgrade.

@risicle
Copy link
Contributor Author

risicle commented Oct 12, 2019

Ok... what order should we do this in?

@veprbl
Copy link
Member

veprbl commented Oct 12, 2019

@risicle Usually we apply fix to master first and then "git cherry-pick -x" to the stable branch.

@risicle
Copy link
Contributor Author

risicle commented Oct 13, 2019

Right... I guess I'll rebase this PR then as a start.

@risicle risicle force-pushed the ris-poppler-CVE-2019-9959 branch from 2d09ae0 to 1316edd Compare October 13, 2019 00:53
@risicle risicle requested a review from adisbladis as a code owner October 13, 2019 00:53
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: vim Advanced text editor 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 13, 2019
@ttuegel ttuegel merged commit df372a0 into NixOS:master Oct 13, 2019
@risicle
Copy link
Contributor Author

risicle commented Oct 13, 2019

Are you going to do the cherry picks or shall I create separate PRs?

@adisbladis
Copy link
Member

adisbladis commented Oct 13, 2019 •
edited by vcunat
Loading

Backported to 19.09 in 3fa2864 31c7bef (edited by vcunat)

vcunat pushed a commit that referenced this pull request Oct 13, 2019
@risicle @vcunat
poppler: add patch for CVE-2019-9959 (PR #71046)
3475116 
(cherry picked from commit 3fa2864)
@vcunat vcunat added 8.has: port to stable This PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 13, 2019
@jtojnar jtojnar mentioned this pull request Oct 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

@edolstra edolstra Awaiting requested review from edolstra

@WilliButz WilliButz Awaiting requested review from WilliButz

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@risicle @veprbl @adisbladis @ttuegel @vcunat