Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PR #64267, add missing release notes and documentation [19.09] #71056



Copy link

@tokudan tokudan commented Oct 12, 2019

Motivation for this change

Backport of #70887 for the 19.09 release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @

tokudan added 2 commits Oct 9, 2019
(cherry picked from commit 8a25551)

(cherry picked from commit a223335)
Copy link

@nixos-discourse nixos-discourse commented Dec 23, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

Copy link
Contributor Author

@tokudan tokudan commented Feb 8, 2020

Closing as it seems unlikely anyone will care.

@tokudan tokudan closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.