Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] nixos/pppd: init #71271

Merged
merged 4 commits into from Jan 10, 2020
Merged

[19.09] nixos/pppd: init #71271

merged 4 commits into from Jan 10, 2020

Conversation

@danderson
Copy link
Contributor

@danderson danderson commented Oct 16, 2019

Motivation for this change

This is a backport of a standalone service module, which is disabled by default. It enables people who need PPP connections (i.e. me :) ) to use NixOS 19.09 as a router.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@fooker
Copy link
Contributor

@fooker fooker commented Nov 7, 2019

The peers option is mission a description. This results in warning.

@danderson danderson force-pushed the danderson:release-19.09 branch 2 times, most recently from 0ec7122 to 50a6c26 Dec 8, 2019
@danderson
Copy link
Contributor Author

@danderson danderson commented Dec 8, 2019

Added additional cherry-pick to fix the warning.

@andir andir force-pushed the danderson:release-19.09 branch from 1d4a7b7 to 9b7bf47 Dec 12, 2019
@andir
Copy link
Member

@andir andir commented Dec 12, 2019

@GrahamcOfBorg test pppd

@danderson
Copy link
Contributor Author

@danderson danderson commented Dec 24, 2019

Tests look good, can we merge this?

danderson and others added 4 commits Oct 14, 2019
(cherry picked from commit c5c5baf)
(cherry picked from commit 997a6f6)
This test creates a PPPoE link between two machines, and verifies
that the machines can ping each other.

(cherry picked from commit ae02b3d)
services.pppd.peers was lacking a description, causing a trace warning
resulting in a parse error in the metrics job.

(cherry picked from commit 0256080)
@danderson danderson force-pushed the danderson:release-19.09 branch from 9b7bf47 to b563ba0 Jan 2, 2020
@danderson
Copy link
Contributor Author

@danderson danderson commented Jan 2, 2020

Rebased to the top of latest release-19.09, checks still pass.

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 10, 2020

Tested today and works just fine.

@andir andir merged commit 01423cb into NixOS:release-19.09 Jan 10, 2020
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.