Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rngd: Start early during boot and encrypted swap entropy fix #71302

Merged
merged 2 commits into from Feb 12, 2020

Conversation

@tokudan
Copy link
Contributor

@tokudan tokudan commented Oct 17, 2019

Motivation for this change

Intended to fix entropy starvation during boot (fixes #71204)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar

@abbradar
Copy link
Member

@abbradar abbradar commented Oct 26, 2019

Interesting, thanks! I'll be able to review this in the upcoming week.

(Sorry for the absence, had a fun traveling accident which greatly prolonged my vacation :D)

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 4, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/what-are-your-goals-for-20-03/4773/15

@tokudan tokudan force-pushed the tokudan:encrypted-swap-entropy-fix branch from d9ccca8 to 6d1d599 Feb 6, 2020
@tokudan
Copy link
Contributor Author

@tokudan tokudan commented Feb 6, 2020

Squashed a commit and rebased onto the current master

@tokudan tokudan changed the title rngd: Start early during boot and encrypted swap entropy fix [WIP] rngd: Start early during boot and encrypted swap entropy fix Feb 6, 2020
@tokudan
Copy link
Contributor Author

@tokudan tokudan commented Feb 6, 2020

I believe this is ready for review/merging

tokudan added 2 commits Oct 17, 2019
avoid entropy starvation during boot
…ion due to encrypted swap and remove PrivateTmp to avoid a circular dependency
@tokudan tokudan force-pushed the tokudan:encrypted-swap-entropy-fix branch from 6d1d599 to d14ba1e Feb 8, 2020
@rnhmjoj
rnhmjoj approved these changes Feb 8, 2020
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Looks good to me.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 10, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/97

@rnhmjoj rnhmjoj merged commit 48704fb into NixOS:master Feb 12, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.