Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macvim: snapshot-157 -> snapshot-161 #71380

Merged
merged 1 commit into from Nov 7, 2019
Merged

macvim: snapshot-157 -> snapshot-161 #71380

merged 1 commit into from Nov 7, 2019

Conversation

@lilyball
Copy link
Member

lilyball commented Oct 19, 2019

Motivation for this change

https://github.com/macvim-dev/macvim/releases/tag/snapshot-159
https://github.com/macvim-dev/macvim/releases/tag/snapshot-160
https://github.com/macvim-dev/macvim/releases/tag/snapshot-161

Things done
  • Tested using sandboxing (using relaxed on macOS, as required by the use of a custom sandbox profile)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot added the 6.topic: vim label Oct 19, 2019
@ofborg ofborg bot requested a review from cstrahan Oct 19, 2019
@lilyball lilyball force-pushed the lilyball:macvim branch from 0e76da9 to a847711 Oct 30, 2019
@lilyball lilyball changed the title macvim: snapshot-157 -> snapshot-159 macvim: snapshot-157 -> snapshot-161 Oct 30, 2019
@lilyball

This comment has been minimized.

Copy link
Member Author

lilyball commented Oct 30, 2019

Updated to snapshot-161.

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Oct 30, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/73

@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Nov 7, 2019

@GrahamcOfBorg build macvim

@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Nov 7, 2019

@lilyball it's failing to build on ofBorg darwin builder and on Hydra with no clear errors.
Any idea why?

@lilyball

This comment has been minimized.

Copy link
Member Author

lilyball commented Nov 7, 2019

@c0bw3b the macvim package requires Xcode to be installed and won't build with the full sandboxed, only the relaxed one. Some day I hope to get it building without Xcode, but for the time being it won't build on ofBorg/Hydra.

@lilyball

This comment has been minimized.

Copy link
Member Author

lilyball commented Nov 7, 2019

I'm not sure why the build log doesn't say anything; I'm not sure why it even gets to the patching stage, I would have expected it to bail early due to the presence of sandboxProfile.

@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Nov 7, 2019

OK. Do you mind adding hydraPlatforms = []; in meta in the meantime?
It would save some Hydra resources for other pkgs.

@lilyball lilyball force-pushed the lilyball:macvim branch from a847711 to 647ee3c Nov 7, 2019
@lilyball

This comment has been minimized.

Copy link
Member Author

lilyball commented Nov 7, 2019

@c0bw3b Done. I was unaware of that attribute or I would have used it sooner.

@c0bw3b c0bw3b merged commit d5cb3fc into NixOS:master Nov 7, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@lilyball lilyball deleted the lilyball:macvim branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.