Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roundcube: fix -- quoting string env variable #71407

Merged
merged 4 commits into from Nov 20, 2019
Merged

Conversation

@f--t
Copy link
Contributor

f--t commented Oct 19, 2019

Motivation for this change

fix the env variable for the case postgresql password contains spaces.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

DinCahill left a comment

I've made a PR on your branch to update the test to show this works. https://github.com/f--t/nixpkgs/pull/1

@DinCahill

This comment has been minimized.

Copy link
Contributor

DinCahill commented Nov 4, 2019

Notifying maintainers @Vskilet @globin

f--t added 2 commits Nov 19, 2019
roundcube: tests - add space to db password, check setup script worked
@globin

This comment has been minimized.

Copy link
Member

globin commented Nov 20, 2019

Hmm should still be quoted properly but better than before at least

@globin globin merged commit 5f7bcff into NixOS:master Nov 20, 2019
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
roundcube on aarch64-linux Success
Details
roundcube on x86_64-linux Success
Details
Ma27 added a commit that referenced this pull request Nov 22, 2019
https://github.com/roundcube/roundcubemail/releases/tag/1.4.1

Also fixed the test which got broken during #71407, most likely due to a
merge issue.
Vskilet added a commit to Vskilet/nixpkgs that referenced this pull request Dec 6, 2019
https://github.com/roundcube/roundcubemail/releases/tag/1.4.1

Also fixed the test which got broken during NixOS#71407, most likely due to a
merge issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.