Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graalvm: Use lib.getVersion for stdenv.cc #71472

Merged
merged 1 commit into from Nov 7, 2019
Merged

Conversation

@regadas
Copy link
Contributor

regadas commented Oct 20, 2019

Attempting to address fix #71471;

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@conferno

This comment has been minimized.

Copy link

conferno commented Oct 21, 2019

I am non sure that native-image will work smoothly with clang
Perhaps stdenv.cc.cc.version -> gcc.cc.version (and stdenv.cc -> gcc in other places) would be more honest

@conferno

This comment has been minimized.

Copy link

conferno commented Oct 21, 2019

It is easier to port graalv8-ee to Darwin, there is just download and unpack instead of long and tricky build process.
It is unfree though, but who will care on an unfree platform?

@hlolli

This comment has been minimized.

Copy link
Contributor

hlolli commented Oct 21, 2019

It would of course be great if this could work for darwin. I have a darwin myself which I use for ios dev. I'm going to bump this derivation this week, and in the process test darwin. I may want to add, that building graalvm from sources is super memory consuming and slow process. So all help appreciated.

@volth

This comment has been minimized.

Copy link
Contributor

volth commented Oct 21, 2019

@hlolli you can try to use NixOS/nix#3036 to avoid restarting the long build process from the beginning on each change (I am using it to work on chromium forks)

@hlolli

This comment has been minimized.

Copy link
Contributor

hlolli commented Oct 22, 2019

Very nice, I'll try this, thanks!

@matthewbauer matthewbauer merged commit 90e5be0 into NixOS:master Nov 7, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@volth

This comment has been minimized.

Copy link
Contributor

volth commented Nov 7, 2019

Why?
It is still actively WIP in #72331

@matthewbauer

This comment has been minimized.

Copy link
Member

matthewbauer commented Nov 7, 2019

lib.getVersion should be preferred over .version regardless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.