Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upgraalvm: Use lib.getVersion for stdenv.cc #71472
Conversation
This comment has been minimized.
This comment has been minimized.
conferno
commented
Oct 21, 2019
I am non sure that |
This comment has been minimized.
This comment has been minimized.
conferno
commented
Oct 21, 2019
It is easier to port |
This comment has been minimized.
This comment has been minimized.
It would of course be great if this could work for darwin. I have a darwin myself which I use for ios dev. I'm going to bump this derivation this week, and in the process test darwin. I may want to add, that building graalvm from sources is super memory consuming and slow process. So all help appreciated. |
This comment has been minimized.
This comment has been minimized.
@hlolli you can try to use NixOS/nix#3036 to avoid restarting the long build process from the beginning on each change (I am using it to work on |
This comment has been minimized.
This comment has been minimized.
Very nice, I'll try this, thanks! |
90e5be0
into
NixOS:master
This comment has been minimized.
This comment has been minimized.
Why? |
This comment has been minimized.
This comment has been minimized.
lib.getVersion should be preferred over |
regadas commentedOct 20, 2019
Attempting to address fix #71471;
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @